nickva commented on a change in pull request #2107: Configurable FDB directory prefixes for CouchDB instances URL: https://github.com/apache/couchdb/pull/2107#discussion_r313530354
########## File path: src/fabric/src/fabric2_server.erl ########## @@ -81,6 +84,14 @@ init(_) -> end, application:set_env(fabric, db, Db), + Dir = case config:get("fabric", "fdb_directory") of + undefined -> + [?DEFAULT_FDB_DIRECTORY]; + Val when is_list(Val), length(Val) > 0 -> Review comment: We look this up once per node start and then it gets saved to the application environment. So even if it is a large-ish value we'd only parse it once. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services