jiangphcn commented on issue #2345: port to spidermonkey 60 URL: https://github.com/apache/couchdb/pull/2345#issuecomment-565694853 Thanks Joan @wohali. I only saw two of them before. ``` In file included from priv/couch_js/main.cpp:26: In file included from /usr/local/include/mozjs-60/js/Wrapper.h:12: /usr/local/include/mozjs-60/js/Proxy.h:212:16: warning: offset of on non-standard-layout type 'js::BaseProxyHandler' [-Winvalid-offsetof] return offsetof(BaseProxyHandler, mFamily); In file included from priv/couch_js/utf8.cpp:16: In file included from /usr/local/include/mozjs-60/js/Wrapper.h:12: /usr/local/include/mozjs-60/js/Proxy.h:212:16: warning: offset of on non-standard-layout type 'js::BaseProxyHandler' [-Winvalid-offsetof] return offsetof(BaseProxyHandler, mFamily); ^ ``` Above looks to be related to spidermonkey so I leave them for now. However, I addressed the second one in your list using f6830c9. Also, thank you for involving more people on this PR.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
