nickva commented on a change in pull request #2666: [WIP] soft-deletion for database URL: https://github.com/apache/couchdb/pull/2666#discussion_r394817206
########## File path: src/fabric/src/fabric_util.erl ########## @@ -23,6 +23,8 @@ -export([validate_all_docs_args/2, validate_args/3]). -export([upgrade_mrargs/1]). -export([worker_ranges/1]). +-export([do_recovery/0]). Review comment: Let's avoid using `fabric_util` and use `fabric2_util` for consistency. However, in this case if we only check the config value once from one module, let's keep it in that module as a local function for now. Wonder if `recovery` or `soft_deletion` is a better name... The discussion so far has used the `soft_deletion` term, maybe we should use that as the config value? The section should probably be `[fabric]` just to keep consistent with other FDB related settings. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
