nickva commented on a change in pull request #2924:
URL: https://github.com/apache/couchdb/pull/2924#discussion_r434824237
##########
File path: src/couch_jobs/src/couch_jobs.erl
##########
@@ -385,10 +385,13 @@ wait_any(Subs, State, Timeout0, ResendQ) when
end.
-limit_timeout(Timeout) when is_integer(Timeout), Timeout < 16#FFFFFFFF ->
+limit_timeout(_Timeout, true) ->
+ infinity;
+
+limit_timeout(Timeout, false) when is_integer(Timeout), Timeout < 16#FFFFFFFF
->
Timeout;
-limit_timeout(_Timeout) ->
+limit_timeout(_Timeout, false) ->
Review comment:
My description was referencing the logic a few API calls higher and was
describing why we need to this.
In this particular clause `limit_timeout` that wouldn't work since
`limit_timeout` is called after we clipped the value to a minimum of 100 msec,
so I would have to put in 100 msec or so there so I opted to make it an
explicit parameter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
