nickva commented on a change in pull request #3043:
URL: https://github.com/apache/couchdb/pull/3043#discussion_r461784853



##########
File path: src/couch_views/src/couch_views_indexer.erl
##########
@@ -407,17 +408,26 @@ fetch_docs(Db, Changes) ->
         }
     end, #{}, erlfdb:wait_for_all(RevFutures)),
 
+    AddLocalSeq = lists:keymember(<<"local_seq">>, 1, DesignOpts),

Review comment:
       `keymember` will indicate that the option is present only? Maybe we want 
a keyfind here http://erlang.org/doc/man/lists.html#keyfind-3 then if tuple is 
present check the value? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to