tonysun83 opened a new pull request #3116:
URL: https://github.com/apache/couchdb/pull/3116


   ## Overview
   
   Previously, we passed in the unpacked version of the bookmark with
   the cursor inside the options field. This worked fine for _find because
   we didn't need to return it to the user. But for _explain, we return
   the value back as unpacked tuple instead of a string and jiffy:encode/1
   complains. Now we correctly extract the bookmark out of options, unpack
   it, and then pass it separately in it's own field. This way options
   retains it's original string form for the user so that invalid_ejson
   is not thrown.
   
   
   ## Testing recommendations
   
   Regression tests should pass. If you create a text index, simply use 
_explain with a bookmark and verify the results. 
   
   ## Related Issues or Pull Requests
   
   <!-- If your changes affects multiple components in different
        repositories please put links to those issues or pull requests here.  
-->
   
   ## Checklist
   
   - [X] Code is written and works correctly
   - [ ] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in 
`rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in 
https://github.com/apache/couchdb-documentation
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to