iilyak commented on a change in pull request #3127: URL: https://github.com/apache/couchdb/pull/3127#discussion_r487064819
########## File path: src/couch_views/src/couch_views_batch.erl ########## @@ -0,0 +1,80 @@ +% Licensed under the Apache License, Version 2.0 (the "License"); you may not +% use this file except in compliance with the License. You may obtain a copy of +% the License at +% +% http://www.apache.org/licenses/LICENSE-2.0 +% +% Unless required by applicable law or agreed to in writing, software +% distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +% WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +% License for the specific language governing permissions and limitations under +% the License. + +-module(couch_views_batch). + + +-export([ + start/1, + success/3, + failure/1 +]). + + +-include_lib("couch_mrview/include/couch_mrview.hrl"). + + +-callback start( + Mrst::#mrst{}, + State::term() + ) -> {NewState::term(), BatchSize::pos_integer()}. + +-callback success( + Mrst::#mrst{}, + TxSize::non_neg_integer(), + DocsRead::non_neg_integer(), Review comment: My understanding is that map function can emit 0 or more documents, therefore `DocsRead /= DocsWritten`: - DocsRead - `length(DocAcc)` - DocsWritten - `length(MappedDocs)` In `couch_rate` the `WrittenDocs` was a result of iterating over `MappedDocs` https://github.com/apache/couchdb/blob/prototype/fdb-layer/src/couch_views/src/couch_views_indexer.erl#L205 The reason I calculated it during iteration is to avoid extra `O(n)` cost on `length(List)`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
