nickva opened a new pull request #3433:
URL: https://github.com/apache/couchdb/pull/3433
Starting with OTP 21 there is a new logging system, and we forgot to add the
legacy error logger handler for it. Without it, we `couch_log` cannot emit
gen_server, supervisor and other such system events.
Luckily, there is OTP support to enable legacy error_logger behavior and
that's what we're doing here. The
add_report_handler/1` call will auto-start the `error_logger` app if
needed, and it also add an `error_logger` handler to the global `logger` system.
We also keep the `gen_event:add_sup_handler/3` call, as that will ensure
we'll find out when error_logger dies so that
`couch_log_monitor` can restart everything.
Someday(TM) we'll write a proper log event handler for the new logger and
have nicely formatted structured logs, but it's better to do that once we don't
have to support OTP versions =< 20.
Issue: https://github.com/apache/couchdb/pull/3422
## Testing recommendations
Build with Erlang/OTP >= 21, then start a dev/run cluster, tail the log and
and remsh in.
```
> exit(whereis(couch_replicator_scheduler), bam).
```
The logs should show something like:
```
Supervisor couch_replicator_sup had child couch_replicator_scheduler started
with couch_replicator_scheduler:start_link() at <0.866.0> exit with reason bam
in context child_terminated
```
Plus a bunch of other crash related stuff, including gen_servers dying.
(Will make a `main` branch PR after this is reviewed)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
