bessbd commented on pull request #3481:
URL: https://github.com/apache/couchdb/pull/3481#issuecomment-811016853
> > I had no heavy QA in mind, just a single-line eunit meck-y check to
assert that couch_mrview:validate is called at the right time. (We could even
assert couch_index_server:validate wasn't called, if that's a fundamental part
of this change.)
>
> Since `couch_index_server:validate/2` is no longer used we could break it
and other tests would fail if we partially revert the PR.
>
> ```
> -module(couch_index_server).
> ...
> validate(_Db, _DDoc) ->
> error({assert, ?MODULE, ?FUNCTION_NAME, ?FUNCTION_ARITY, ?LINE}).
> ```
I didn't know that `couch_index_server:validate` would become dead code
after this change. So we might as well remove the `fun` altogether then, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
