Terreii commented on a change in pull request #3483:
URL: https://github.com/apache/couchdb/pull/3483#discussion_r605214013
##########
File path: src/couch/src/couch_users_db.erl
##########
@@ -86,7 +90,63 @@ save_doc(#doc{body={Body}} = Doc) ->
Doc#doc{body={Body4}};
{_ClearPassword, Scheme} ->
couch_log:error("[couch_httpd_auth] password_scheme value of '~p' is
invalid.", [Scheme]),
- throw({forbidden, "Server cannot hash passwords at this time."})
+ throw({forbidden, ?PASSWORD_SERVER_ERROR})
+ end.
+
+% Validate if a new password matches all RegExp in the password_reqexp setting.
+% Throws if not.
+validate_password(ClearPassword) ->
+ case config:get("couch_httpd_auth", "password_reqexp", "") of
+ "" ->
+ ok;
+ "[]" ->
+ ok;
+ ValidateConfig ->
+ case couch_util:parse_term(ValidateConfig) of
+ {ok, RegExpList} when is_list(RegExpList) ->
+ % Check the password on every RegExp.
+ Loop = fun(RegExp) ->
+ check_password_with_regexp(ClearPassword, RegExp)
+ end,
+ lists:foreach(Loop, RegExpList),
+ ok;
+ {ok, NonListValue} ->
+ couch_log:error(
+ "[couch_httpd_auth] password_reqexp value of '~p' is invalid.",
+ [NonListValue]
+ ),
+ throw({forbidden, ?PASSWORD_SERVER_ERROR});
Review comment:
If in
[`save_doc/1`](https://github.com/apache/couchdb/blob/776f920021dd15c51355e9a904bdc5a2250b19d9/src/couch/src/couch_users_db.erl#L89)
the `[couch_httpd_auth] password_scheme` config has an invalid value, the user
will receive an 403 status. I also used 403 for all instances where a part of
`[couch_httpd_auth] password_regexp` is wrong.
In the latest commit, I changed the status code for "malformed" password to
400.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
