awalterschulze commented on pull request #3568:
URL: https://github.com/apache/couchdb/pull/3568#issuecomment-859479642


   > @awalterschulze after playing around in an editor with some erlfmt 
formatted CouchDB code, I find it all pretty readable, and generally an 
improvement, with only one real exception. CouchDB style has evolved to put a 
blank line between function clauses, and 2 blank lines between functions. After 
formatting, these get changed to no 0 and 1 respectively. I wonder if your team 
would consider respecting the original format for this case as well as [the 
others you already honor 
here](https://github.com/WhatsApp/erlfmt#respecting-original-format)?
   
   Thank you @jaydoane it is really great to hear that you find erlfmt to be a 
general improvement.
   
   Sorry for taking so long to get back to you, but we needed to give this some 
thought.
   The problem with preserving the spacing for this case though, is it would 
result in a lot of inconsistency caused by users.
   If anything this would need to be an enforced style, but that would need to 
be configured and erlfmt does not to config.
   We want erlfmt to enforce an opinionated style.
   We did consider this format before as the opinionated style, as we very much 
liked this idea from Elixir.
   But we found this style is uncommon in erlang code bases.
   I hope that makes sense.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to