iilyak commented on a change in pull request #3766:
URL: https://github.com/apache/couchdb/pull/3766#discussion_r740144764
##########
File path: src/smoosh/src/smoosh_channel.erl
##########
@@ -177,21 +187,34 @@ handle_info(check_window, State0) ->
erlang:send_after(60 * 1000, self(), check_window),
{noreply, FinalState};
+handle_info(persist_queue, State0) ->
+ #state{waiting=Queue} = State0,
+ smoosh_priority_queue:write_to_file(Queue),
+ AutoSave = config:get_integer("smoosh", "save_time",
?DEFAULT_AUTOSAVE_PERIOD),
Review comment:
Naming is hard!!!
`save_time` doesn't reflect what the setting is doing. I am thinking
something like the following would be better:
- `state_checkpoint_interval_in_sec`
- `state_autosave_interval_in_sec`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
