lostnet commented on code in PR #15: URL: https://github.com/apache/couchdb-glazier/pull/15#discussion_r852928233
########## moz/sm-opt: ########## @@ -0,0 +1,24 @@ +# Build only the JS shell +ac_add_options --enable-application=js + +# Enable optimization for speed +ac_add_options --enable-optimize + +# Disable debug checks to better match a release build of Firefox. +ac_add_options --disable-debug + +ac_add_options --disable-ctypes +ac_add_options --disable-jit +ac_add_options --disable-jemalloc +ac_add_options --enable-hardening +ac_add_options --with-intl-api +ac_add_options --build-backends=RecursiveMake +#ac_add_options --with-system-icu Review Comment: I can't be sure in the mach build but on legacy builds, doing `choco install pkgconfiglite` causes the attempt to use pkgconf to non-fatal (but not be helpful at finding ICU), while the env variables (PATH,LIB,INCLUDE) set in shell.ps1 make icu directly discoverable by the build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
