big-r81 commented on code in PR #15: URL: https://github.com/apache/couchdb-glazier/pull/15#discussion_r857123683
########## moz/sm-opt: ########## @@ -0,0 +1,24 @@ +# Build only the JS shell +ac_add_options --enable-application=js + +# Enable optimization for speed +ac_add_options --enable-optimize + +# Disable debug checks to better match a release build of Firefox. +ac_add_options --disable-debug + +ac_add_options --disable-ctypes +ac_add_options --disable-jit +ac_add_options --disable-jemalloc +ac_add_options --enable-hardening +ac_add_options --with-intl-api +ac_add_options --build-backends=RecursiveMake +#ac_add_options --with-system-icu Review Comment: Summary of our discussion and observations from Slack: 1. Compiling sm without `--with-system-icu`builds all icu functions into the mozjs-dll, with no external dependencies to the icu lib 2. Far fewer problems compiling the SpiderMonkey library (under windows), like no need for pkgconfiglite, setting different env vars, some in PS, some in the Mozilla build env 3. link the CouchDB nifs against the icu lib from VCPKG (like before) 4. ATM, no problems at the moment between the external ICU library and the integrated SpiderMonkey ICU functionality -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
