nickva commented on code in PR #4240:
URL: https://github.com/apache/couchdb/pull/4240#discussion_r1005835215


##########
src/couch/src/couch_server.erl:
##########
@@ -381,7 +369,7 @@ handle_config_change("couchdb_engines", _, _, _, N) ->
     {ok, N};
 handle_config_change("admins", _, _, Persist, N) ->
     % spawn here so couch event manager doesn't deadlock
-    spawn(fun() -> hash_admin_passwords(Persist) end),
+    couch_password_server:hash(true, Persist),

Review Comment:
   `N` is the couch_server process number `1 ... $(number_of_schedulers)`. So 
in handle_config_change ... we'd replace `N` with `1`. So the first 
couch_server would do the hashing or stopping of httpd and the rest would 
ignore it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to