willholley commented on code in PR #105: URL: https://github.com/apache/couchdb-helm/pull/105#discussion_r1063630994
########## docs/index.yaml: ########## @@ -1,6 +1,30 @@ apiVersion: v1 entries: couchdb: + - apiVersion: v1 + appVersion: 3.2.1 + created: "2022-12-20T17:53:44.680236109-08:00" + description: A database featuring seamless multi-master sync, that scales from + big data to mobile, with an intuitive HTTP/JSON API and designed for reliability. + digest: 5a66b7584d72bb2ac9c30e65d751ee374adbea2fe73dac20a058fb20bf1476e2 + home: https://couchdb.apache.org/ + icon: http://couchdb.apache.org/CouchDB-visual-identity/logo/CouchDB-couch-symbol.svg + keywords: + - couchdb + - database + - nosql + maintainers: + - email: [email protected] + name: kocolosk + - email: [email protected] + name: willholley + name: couchdb + sources: + - https://github.com/apache/couchdb-helm + - https://github.com/apache/couchdb-docker + urls: + - couchdb-3.6.4.tgz + version: 3.6.4 - apiVersion: v1 appVersion: 3.2.1 created: "2022-11-16T10:04:19.187911144-08:00" Review Comment: This doesn't need to be manually updated - it's now generated automatically on release. We need to update the contributing guide / remove the docs folder... ########## couchdb/Chart.yaml: ########## @@ -1,6 +1,6 @@ apiVersion: v1 name: couchdb -version: 3.6.3 +version: 3.6.4 Review Comment: Can you rebase / re-bump the version please? ########## couchdb/templates/persistentvolumeclaim.yaml: ########## @@ -0,0 +1,29 @@ +{{- if and .Values.persistentVolume.enabled .Values.persistentVolume.existing -}} +apiVersion: v1 +kind: PersistentVolumeClaim +metadata: + name: {{ .Values.persistentVolume.claimName }} + labels: + app: {{ template "couchdb.name" . }} + release: {{ .Release.Name }} + {{- with .Values.persistentVolume.annotations }} + annotations: + {{- toYaml . | nindent 10 }} Review Comment: nindent value here is probably 6 rather than 10? I assume it is 10 since it was copied from the statefulset yaml? It feels like there's some potential for the persistentvolumeclaim.yaml and statefulset.yaml to get out of sync - perhaps we could extract a helper function for the common yaml? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
