willholley commented on code in PR #106: URL: https://github.com/apache/couchdb-helm/pull/106#discussion_r1064660944
########## couchdb/README.md: ########## @@ -86,6 +79,7 @@ and then install the chart while overriding the `createAdminSecret` setting: $ helm install \ --name my-release \ --version=3.6.1 \ + --set adminHash=true/false \ Review Comment: I think we should avoid overloading the meaning of `adminHash` value to support the bring-your-own secret use case. The [pattern used across Bitnami charts](https://github.com/helm/charts/blob/master/stable/keycloak/values.yaml#L62-L66) would be reasonable to copy and/or the proposal in #72 might support this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
