willholley commented on code in PR #4472:
URL: https://github.com/apache/couchdb/pull/4472#discussion_r1134427030
##########
src/couch_prometheus/test/eunit/couch_prometheus_e2e_tests.erl:
##########
@@ -105,6 +106,22 @@ t_reject_prometheus_port(Port) ->
Response = test_request:get(node_local_url(Port), [?CONTENT_JSON, ?AUTH]),
?assertEqual({error, {conn_failed, {error, econnrefused}}}, Response).
+t_no_duplicate_metrics(Port) ->
+ Url = node_local_url(Port),
+ Stats = get_stats(Url),
+ Lines = re:split(Stats, "\n"),
+ % Filter the result to only the lines containing the metric
+ % definition, not the values. These lines always start with
+ % a # character.
+ MetricDefs = lists:filter(fun(S) -> string:find(S, "#") =:= S end, Lines),
+ ?assertNotEqual(erlang:length(MetricDefs), 0),
+ Diff = get_duplicates(MetricDefs),
+ ?debugVal(Diff),
Review Comment:
good spot - now removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
