rnewson commented on code in PR #4659:
URL: https://github.com/apache/couchdb/pull/4659#discussion_r1269428870
##########
src/mango/src/mango_idx_nouveau.erl:
##########
@@ -307,7 +307,7 @@ construct_analyzer({Props}) ->
indexable_fields(Selector) ->
TupleTree = mango_selector_text:convert([], Selector),
- indexable_fields([], TupleTree).
+ ordsets:to_list(indexable_fields(ordsets:new(), TupleTree)).
Review Comment:
the docs for ordsets says `Elements are ordered according to the Erlang term
order.`. If the intent is to preserve the original order, neither ordsets or
usort/ukeysort seems to be right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
