nickva commented on code in PR #4814: URL: https://github.com/apache/couchdb/pull/4814#discussion_r1383534528
########## rebar.config.script: ########## @@ -157,7 +157,8 @@ DepDescs = [ {jiffy, "jiffy", {tag, "CouchDB-1.0.9-2"}}, {mochiweb, "mochiweb", {tag, "v3.2.1"}}, {meck, "meck", {tag, "0.9.2"}}, -{recon, "recon", {tag, "2.5.3"}} +{recon, "recon", {tag, "2.5.3"}}, +{fast_pbkdf2, {url, "https://github.com/esl/fast_pbkdf2"}, {tag, "1.0.2"}} Review Comment: Since we're planning a CouchDB release soon-ish, wonder if it makes sense to just vendor it for now? At some point https://github.com/erlang/otp/pull/7770 will merge then if we made a release with https://github.com/esl/fast_pbkdf2's mirror we'd have to archive it and keep it essentially forever. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org