nickva commented on code in PR #4814:
URL: https://github.com/apache/couchdb/pull/4814#discussion_r1388694964
##########
src/couch/src/couch_primary_sup.erl:
##########
@@ -23,7 +23,18 @@ init([]) ->
{couch_task_status, {couch_task_status, start_link, []},
permanent, brutal_kill, worker,
[couch_task_status]},
{couch_password_hasher, {couch_password_hasher, start_link, []},
permanent, brutal_kill,
- worker, [couch_password_hasher]}
+ worker, [couch_password_hasher]},
+ {couch_passwords_cache_lru,
+ {ets_lru, start_link, [
+ couch_passwords_cache_lru,
+ [
+ {max_objects,
+ config:get_integer("couch_passwords_cache",
"max_objects", 10_000)},
+ {max_lifetime,
+ config:get_integer("couch_passwords_cache",
"max_lifetime", 360_000)}
Review Comment:
For max_lifetime was the intention to make it 6 minutes or an hour? The unit
it in milliseconds so if it should be an hour it would be `3_600_000`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
