big-r81 commented on code in PR #4956:
URL: https://github.com/apache/couchdb/pull/4956#discussion_r1446692363
##########
configure.ps1:
##########
@@ -140,7 +140,6 @@ $InstallDir="$LibDir\couchdb"
$LogFile="$LogDir\couch.log"
$BuildFauxton = [int](-not $DisableFauxton)
$BuildDocs = [int](-not $DisableDocs)
-$BuildNouveau = $(If ($EnableNouveau) {1} else {0})
Review Comment:
iirc, there was a reason to do it that way. $false will get to False, but I
need to test this in powershell ...
##########
configure.ps1:
##########
@@ -140,7 +140,6 @@ $InstallDir="$LibDir\couchdb"
$LogFile="$LogDir\couch.log"
$BuildFauxton = [int](-not $DisableFauxton)
$BuildDocs = [int](-not $DisableDocs)
-$BuildNouveau = $(If ($EnableNouveau) {1} else {0})
Review Comment:
Example:
```powershell
$EnableNouveau = $false
$CouchDBConfig = @"
{nouveau_enable, "$EnableNouveau"}.
"@
Write-Output "$CouchDBConfig"
```
Result:
```
PS F:\> .\test.ps1
{nouveau_enable, "False"}.
```
Can this be a problem later with the capital "F"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
