jaydoane commented on code in PR #4962:
URL: https://github.com/apache/couchdb/pull/4962#discussion_r1453993580
##########
src/couch/src/couch_multidb_changes.erl:
##########
@@ -119,6 +140,12 @@ handle_call({checkpoint, DbName, EndSeq}, {Pid, _Tag} =
_From, #state{tid = Ets}
handle_cast({resume_scan, DbName}, State) ->
{noreply, resume_scan(DbName, State)}.
+handle_info({'$couch_event', Dbs, updated}, #state{dbs = Dbs, tref =
undefined} = State) ->
Review Comment:
Does this line require the shards db in the couch_event message to match the
shards db in state? Why is that necessary?
##########
src/couch/src/couch_multidb_changes.erl:
##########
@@ -47,16 +47,25 @@
event_server :: reference(),
scanner :: nil | pid(),
pids :: #{},
- skip_ddocs :: boolean()
+ skip_ddocs :: boolean(),
+ dbs :: binary(),
Review Comment:
If it doesn't overflow any lines, consider calling this `shards_db`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
