pgj commented on code in PR #4958:
URL: https://github.com/apache/couchdb/pull/4958#discussion_r1485615206
##########
src/fabric/src/fabric_view.erl:
##########
@@ -241,11 +246,63 @@ possibly_embed_doc(
end;
_ ->
Row
+ end;
+possibly_embed_doc(
+ #collector{db_name = DbName, query_args = Args},
+ #{key := _Key, id := _Id, value := Value, doc := _Doc} = Row
Review Comment:
I guess those names with the underscore prefix were spelled out for
documentation. I do not think they do any harm as the compiler automatically
discards them due to the underscore in the beginning. Maintaining readability
could always come in handy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
