nickva commented on code in PR #5204:
URL: https://github.com/apache/couchdb/pull/5204#discussion_r1730026330


##########
src/docs/src/whatsnew/3.4.rst:
##########
@@ -39,6 +39,14 @@ Breaking Changes
   We recommend adding ``nbf`` as a required claim if you know your tokens will
   include it.
 
+* :ghissue:`5203`: Continuous change feeds with ``descending=true&limit=N``
+
+  Previously, ``_changes?feed=continuous&descending=true&limit=N`` with ``N``
+  greater than total rows would block and wait on database changes. On each
+  change the first few sequence rows (sequences ``1-...``, ``2-...``) were
+  repeatedly emitted. The new behavior is to return after all the rows are

Review Comment:
   I tried another version. I think we want to emphasize that the previous 
behavior was non-sensical and downright broken, not as much that we picked one 
option vs another, almost as reasonable, option.
   
   In other words, I could see viewing it as a trade-off if we had actually 
emitted the newly updated row in phase 2. Something like: `3, 2, 1, (phase2)... 
4, 5, 6`.  Instead we did `3,2,1, (phase2)... 2,1,2,1...`. So the users go an 
indication that something changed in the database, but never got the actual 
changed row, just some of the old rows.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to