nickva commented on PR #5244:
URL: https://github.com/apache/couchdb/pull/5244#issuecomment-2350986682

   I had forgotten to update the tests. Now I fixed them to use open_port 
command just like couch_os_proc does, so the test is close to the code we ship. 
Also, instead of the tests looking through the output I look at the exit code.
   
   
https://github.com/apache/couchdb/blob/902d973c3fc9d6c4ab1c3eb5743d517bfbfbb1a7/src/couch/src/couch_os_process.erl#L137


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to