iilyak commented on code in PR #5341:
URL: https://github.com/apache/couchdb/pull/5341#discussion_r1856700329


##########
src/mango/test/16-index-selectors-test.py:
##########
@@ -189,6 +189,7 @@ def 
test_uses_partial_index_with_non_indexable_selector(self):
 @unittest.skipUnless(mango.has_text_service(), "requires text service")
 class IndexSelectorText(mango.DbPerClass):
     def setUp(self):
+        self.db = 
mango.Database(f"{mango.random_db_name()}_{str(self).split()[0]}")

Review Comment:
   All time based approaches are flowed. They don't solve the problem. They 
introduce flakiness. The options I see:
   
   1. restructure all tests so they are not using recreate. They would always 
start from scratch and create fresh databaase with uniq name. 
   2. update dreyfus_index_manager.erl to handle `cleanup` differently
   3.  modify clouseau so it handle rapid re-creation better
   4. change recreate function so it uses new name on each retry



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to