nickva commented on PR #5371:
URL: https://github.com/apache/couchdb/pull/5371#issuecomment-2575778127

   > it's hard enough to get CI to run for one pull request. I'll do it this 
time but I really don't like this idea at all. I separated out the refactoring 
from the functional change within the PR and it makes little sense to commit 
one without the other.
   
   I think it's worthwhile. At least in this case the test failures do seem 
related to bulk_docs:
   
   ```
   07:52:20  7) test bulk docs emits conflict error for duplicate doc `_id`s 
(BulkDocsTest)
   07:52:20       test/elixir/test/bulk_docs_test.exs:124
   07:52:20       Expected 201 and the same number of response rows as in 
request, but got
   07:52:20       %HTTPotion.Response{
   07:52:20         status_code: 500,
   07:52:20         body: [
   07:52:20           %{
   07:52:20             "error" => "conflict",
   07:52:20             "id" => "0",
   07:52:20             "reason" => "Document update conflict."
   07:52:20           },
   07:52:20           %{
   07:52:20             "error" => "conflict",
   07:52:20             "id" => "1",
   07:52:20             "reason" => "Document update conflict."
   07:52:20           },
   07:52:20           %{
   07:52:20             "error" => "conflict",
   07:52:20             "id" => "1",
   07:52:20             "reason" => "Document update conflict."
   07:52:20           },
   07:52:20           %{
   07:52:20             "error" => "error",
   07:52:20             "id" => "3",
   07:52:20             "reason" => "internal_server_error"
   07:52:20           }
   07:52:20         ],
   ```
   I keep an eye on flaky failures in the CI and this not a test that usually 
fails. `internal_server_error` seems worrying there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to