pgj commented on PR #5454: URL: https://github.com/apache/couchdb/pull/5454#issuecomment-2701920184
> The retry loop for clouseau shouldn't be necessary Yeah, it should seldom fail. Without a strong argument, it is hard to see why that is needed. I am sure the submitter had a reason to make this change, though. > the many new echo lines seem noisy to me Agreed. One could consider leaving these lines in but definitely tied to a flag that controls the level of verbosity. Or make the script more vocal in case of errors only, otherwise they do not seem to be that exciting. > the PR doesn't have a description. Agreed. Please provide a description. I could gather something about the intentions from the commit logs, but they do not precisely reflect the changes either. For example, one of them says "add explicit validation for the Clouseau method", while it adjusts the error message only. Also, please remember to update the `configure.ps1` script at the same time to keep that one in sync as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
