nickva commented on code in PR #5552:
URL: https://github.com/apache/couchdb/pull/5552#discussion_r2114756699


##########
src/mem3/src/mem3_sup.erl:
##########
@@ -21,16 +21,15 @@ init(_Args) ->
     Children = [
         child(mem3_events),
         child(mem3_nodes),
-        child(mem3_distribution),
-        child(mem3_seeds),
-        % Order important?

Review Comment:
   Good idea, Jay. Using a `rest_for_one` supervisor sort of implicitly 
indicates that order is important. But I can see a comment in there being 
useful as well, as it took a while to untangle all the calls. I'll update it 
with the comment from the commit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to