iilyak commented on code in PR #5603:
URL: https://github.com/apache/couchdb/pull/5603#discussion_r2222442008
##########
src/mem3/src/mem3_util.erl:
##########
@@ -172,6 +171,11 @@ update_db_doc(DbName, #doc{id = Id, body = Body} = Doc,
ShouldMutate) ->
couch_db:close(Db)
end.
+range_to_hex([B, E]) when is_integer(B), is_integer(E) ->
Review Comment:
This function always used with `list_to_binary/1` like.
```erlang
list_to_binary(mem3_util:range_to_hex([B, E])),
```
Maybe make this function to return binary in a first place. We can also
create two functions when we need another variant
- `range_to_hex_as_string/1`
- `range_to_hex_as_binary/1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
