nickva commented on code in PR #5603:
URL: https://github.com/apache/couchdb/pull/5603#discussion_r2222934437
##########
src/couch/src/couch_bt_engine_header.erl:
##########
@@ -330,6 +337,19 @@ upgrade_compacted_seq(#db_header{} = Header) ->
Header
end.
+upgrade_time_seq(#db_header{} = Header) ->
+ MaybeTSeq = Header#db_header.time_seq,
+ case couch_time_seq:check(MaybeTSeq) of
+ true ->
+ TSeq = couch_time_seq:new(MaybeTSeq),
Review Comment:
The idea is that the `check()` and the `new ()` would be updated together.
So on a version 2, both `check()` and `new()` get new clauses: `check(OldVer)`
should return true and `new(OldVer)` should handle the upgrade. I'll add a
comment about, good spot that it missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
