digitalextremist opened a new pull request, #358: URL: https://github.com/apache/couchdb-nano/pull/358
One approach to apache/couchdb-nano#356 ## Overview Intended to resolve #356 That was originally seen as fixing a syntax error, but the syntax error existed because of a theory error. By that theory error, when an `Error` was thrown on a request, the message is being lost. ## Reasoning This has already met `!response.status` which means it is more than likely `error` and not `response` being called `response` due to the theory error, since the design does not have a separate `responseHandler` for errors. Because of that, I check `response.message` first, then `response.cause?.toString()` ( includes the fitch requested by #356 ) ## Testing recommendations - [ ] Use with no server online ( per https://github.com/apache/couchdb-nano/issues/356#issuecomment-3287835196 case ) --- Since this is a small change of one line ... but might trigger a refactor since there is a theory error still: - [ ] I am putting this out there for discussion first - [ ] I have not run this in my environment yet - [ ] Still needs a test added - [ ] Refactor more likely needed which will invalidate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
