nickva commented on code in PR #5673:
URL: https://github.com/apache/couchdb/pull/5673#discussion_r2369165098
##########
src/couch/src/couch_query_servers.erl:
##########
@@ -278,7 +278,7 @@ sum_arrays(Else, _) ->
throw_sum_error(Else).
check_sum_overflow(InSize, OutSize, Sum) ->
- Overflowed = OutSize > 4906 andalso OutSize * 2 > InSize,
+ Overflowed = OutSize > overflow_threshold() andalso OutSize *
overflow_ratio() > InSize,
Review Comment:
Originally these are mirroring the ones from the custom view reducer. It
would odd if we made these configurable but not those. For those it's a bit
more elaborate as we'd have to pass them through to the js view engines and
handle the overflow in javascript. Do we just want to adjust the thresholds
perhaps? I can see maybe 1.5 being a better value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
