big-r81 commented on code in PR #5702:
URL: https://github.com/apache/couchdb/pull/5702#discussion_r2436838973
##########
src/couch_replicator/test/eunit/couch_replicator_test_helper.erl:
##########
@@ -206,6 +206,7 @@ test_setup() ->
Hashed = couch_passwords:hash_admin_password(?PASSWORD),
Persist = false,
ok = config:set("admins", ?USERNAME, ?b2l(Hashed), Persist),
+ ok = config:set("replicator", "use_bulk_get", "true", Persist),
Review Comment:
> use_bulk_get should already default to true or is some test leaving it
disabled? in that case we should fix that test
`couch_replicator_bulk_get_tests.erl` sets it explicit to `false` in
[job_enable_overrides_global_disable](https://github.com/apache/couchdb/blob/26920c21f82be1ab7297feab69e052e437fbe406/src/couch_replicator/test/eunit/couch_replicator_bulk_get_tests.erl#L112)
and
[global_disable_works](https://github.com/apache/couchdb/blob/26920c21f82be1ab7297feab69e052e437fbe406/src/couch_replicator/test/eunit/couch_replicator_bulk_get_tests.erl#L124),
and don't reset it back ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
