nickva commented on code in PR #12:
URL: https://github.com/apache/couchdb-rebar/pull/12#discussion_r2461071326
##########
src/rebar_ct.erl:
##########
@@ -288,7 +288,7 @@ search_ct_specs_from(Cwd, TestDir, Config) ->
build_name(Config) ->
%% generate a unique name for our test node, we want
%% to make sure the odds of name clashing are low
- Random = integer_to_list(crypto:rand_uniform(0, 10000)),
+ Random = integer_to_list(rand:uniform(10000)),
Review Comment:
Technically the ranges here might be 1 off but not sure how much that
matters in practice. For instance, `rand:uniform/1` won't produce 0s its `[1,
Hi]` range so `[1, 10000]`. rand_uniform looks like produces values in `[Lo,
Hi)` range so `[0, 10000)`
I don't think it really matters here but it's worth noting just in case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
