nickva commented on code in PR #5717:
URL: https://github.com/apache/couchdb/pull/5717#discussion_r2467956806
##########
src/mango/rebar.config.script:
##########
@@ -13,16 +13,10 @@
% the License.
-HaveDreyfus = code:lib_dir(dreyfus) /= {error, bad_name}.
+ErlOpts = case lists:keyfind(erl_opts, 1, CONFIG) of
+ {erl_opts, Opts} -> Opts;
+ false -> []
+end,
-if not HaveDreyfus -> CONFIG; true ->
- CurrOpts = case lists:keyfind(erl_opts, 1, CONFIG) of
- {erl_opts, Opts} -> Opts;
- false -> []
- end,
- NewOpts = [
- {d, 'HAVE_DREYFUS'}
Review Comment:
I think there may be a few place we expected this to be defined, like in
ken_server or mango_cursor_text. Search for `HAVE_DREYFUS` in the code, maybe
we could clean those up as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
