nickva commented on code in PR #5830:
URL: https://github.com/apache/couchdb/pull/5830#discussion_r2638942396
##########
Makefile:
##########
@@ -193,6 +193,8 @@ eunit: export ERL_AFLAGS = -config
$(CURDIR)/rel/files/eunit.config
eunit: export COUCHDB_QUERY_SERVER_JAVASCRIPT = $(CURDIR)/bin/couchjs
$(CURDIR)/share/server/main.js
eunit: export COUCHDB_TEST_ADMIN_PARTY_OVERRIDE=1
eunit: ${SUBDIRS}
+ @cat tmp/couchdb-tests/*/log/couch.log > tmp/couch.log
Review Comment:
In case of an eunit failure we won't run the commands here so we won't get
all the logs. We only get them on success. But we may want the opposite case -
in case of success ignore them, but in case of failure inspect them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
