rnewson commented on code in PR #5952:
URL: https://github.com/apache/couchdb/pull/5952#discussion_r3008672154
##########
share/server/nouveau.js:
##########
@@ -75,7 +75,7 @@ var Nouveau = (function () {
case 'stored':
var value = arguments[2];
if (typeof value != 'number' && typeof value != 'string') {
- throw ({ name: 'TypeError', message: 'type of ' + value + ' must
be a string or number' });
+ throw ({ name: 'TypeError', message: 'type of value must be a
string or number not ' + typeof value });
Review Comment:
good catch! I think we should include `name` in this string too, so that an
error reads `type of 'foo' must be a string or number not object` for example.
so `name` where `value` previous was but keep the typeof value at the end?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
