willholley commented on code in PR #5983:
URL: https://github.com/apache/couchdb/pull/5983#discussion_r3160441491
##########
src/couch_replicator/src/couch_replicator_httpc.erl:
##########
@@ -113,6 +114,10 @@ send_ibrowse_req(#httpdb{headers = BaseHeaders} = HttpDb0,
Params) ->
{Headers2, HttpDb} = couch_replicator_auth:update_headers(HttpDb0,
Headers1),
Url = full_url(HttpDb, Params),
Body = get_value(body, Params, []),
+
+ % Apply DNS override using connect_to ibrowse option
+ #url{host = Host, protocol = Protocol} = ibrowse_lib:parse_url(Url),
Review Comment:
I did wonder about the performance overhead but it seems negligible in the
grand scheme of things? If you think it beneficial, I can explore it (may need
guidance though!).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
