Mahagon opened a new pull request, #295:
URL: https://github.com/apache/couchdb-helm/pull/295

   chore: update chart-testing version to v3.14.0
   chore: update KinD version to v0.31.0
   chore: update Kubernetes version for testing to v1.35.1
   chore: add missing values in README.md.gotmpl
   
   fixes: #254
   
   <!--
   Thank you for contributing to couchdb-helm. Before you submit this PR we'd 
like to
   make sure you are aware of the chart technical requirements and best 
practices:
   
   * 
https://github.com/helm/charts/blob/master/CONTRIBUTING.md#technical-requirements
   * https://github.com/helm/helm/tree/master/docs/chart_best_practices
   
   For a quick overview across what we will look at reviewing your PR, please 
read
   our review guidelines:
   
   * https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md
   
   Following our best practices right from the start will accelerate the review 
process and
   help get your PR merged quicker.
   
   When updates to your PR are requested, please add new commits and do not 
squash the
   history. This will make it easier to identify new changes. The PR will be 
squashed
   anyways when it is merged. Thanks.
   
   Please make sure you test your changes before you push them.
   -->
   
   #### What this PR does / why we need it:
   
   Wanted to test your Chart for the first time and the post install job fails, 
as the couchdb wasn't ready initializing, so i wanted to make backoffLimit 
variable.
   I also saw a bunch of outdated versions in the e2e test and updated them
   And the Readme.md.gotmpl did not fit the Readme.md anymore.
   
   had to set validate-maintainers: false as the e2e test failed otherwise on 
my local machine, as it tried to reach localhost on port 53 and i do not run a 
local dns service.
   
   #### Which issue this PR fixes
   
   #254 
   
   #### Special notes for your reviewer:
   
   #### Checklist
   [Place an '[x]' (no spaces) in all applicable fields. Please remove 
unrelated fields.
   - [x] Chart Version bumped
   - [x] e2e tests pass
   - [x] Variables are documented in the README.md
   - [x] NEWS.md updated
   
   
   
   E2E test results (local)
   
   
------------------------------------------------------------------------------------------------------------------------
    ✔︎ couchdb => (version: "4.6.4", path: "couchdb")
   
------------------------------------------------------------------------------------------------------------------------
   All charts linted and installed successfully


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to