rnewson commented on code in PR #6024:
URL: https://github.com/apache/couchdb/pull/6024#discussion_r3358939093
##########
src/couch/src/couch_server.erl:
##########
@@ -998,7 +999,9 @@ name(BaseName, N) when is_integer(N), N > 0 ->
list_to_atom(BaseName ++ "_" ++ integer_to_list(N)).
num_servers() ->
- erlang:system_info(schedulers).
+ Max = config:get_integer("couchdb", "max_couch_server_shards",
?DEFAULT_SHARDS),
Review Comment:
if the value was changed since boot we will get serious failures, no? we'd
try to contact couch_server_X process that doesn't exist etc.
Think this should be an application environment variable _or_ we store the
max_couch_server_shards value into a persistent_term at startup (when
couch_primary_sup is generating the list of couch_server children)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
