nickva commented on code in PR #6031:
URL: https://github.com/apache/couchdb/pull/6031#discussion_r3389419542
##########
src/couch_replicator/src/couch_replicator_docs.erl:
##########
@@ -209,6 +215,22 @@ open_rep_doc(DbName, DocId) ->
Else
end.
+save_rep_doc(<<"shards/", _/binary>> = ShardDbName, Doc) ->
Review Comment:
If this call happens from a multidb changes listener (I pretty sure it is)
we'd have a case when the changes replication scanner on a local set of
_replicator shards will block on a clustered call. It's a cleaner design but
may have performance implications, which is why I think? we moved to a
node-local update mechanism from a clustered one in the past. (That's why in my
PR I kept the local write as is and spawned an async internal-replicator-like
push to other shards, just more eager than the actual internal replicator)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
