jcoglan commented on code in PR #5858:
URL: https://github.com/apache/couchdb/pull/5858#discussion_r3394741750
##########
src/mango/src/mango_native_proc.erl:
##########
@@ -95,6 +100,12 @@ handle_call({prompt, [<<"nouveau_index_doc">>, Doc]},
_From, St) ->
Else
end,
{reply, Vals, St};
+handle_call({prompt, [<<"validate_fun">>, Selector0 | _Rest]}, _From, St) ->
+ Selector = mango_selector:normalize(Selector0),
Review Comment:
I'm not sure what you mean by "protected" here, can you tell me what I ought
to do here to make this safe? If `normalize()` can fail, shouldn't it be
returning something like `{ok|error, Value}` instead of just the normalized
selector?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
