DanielRamosAcosta commented on PR #6053:
URL: https://github.com/apache/couchdb/pull/6053#issuecomment-4827044698
Two refactors I deliberately left out to keep this diff small and easy to
review:
1. The client IP resolution lives in `couch_auth_lockout`, but conceptually
it belongs to the HTTP layer where `#httpd.peer` is computed (`chttpd.erl`).
Moving it there would also give access logging and external handlers the real
client IP, instead of only the lockout. I kept it local on purpose, matching
the "simplest move" suggested in #6052.
2. The lockout identity `{Peer, UserName, UserSalt}` is a recurring tuple
across `is_locked_out_int/4` and `lockout/3`, and `UserName`/`UserSalt` travel
together through the public API. That predates this change and touching it
would widen the diff into the exported API, so I left it as is.
Happy to follow up on either in a separate PR if there is interest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
