glynnbird commented on issue #381: URL: https://github.com/apache/couchdb-nano/issues/381#issuecomment-6452495416
That would be great On Tue, 27 Oct 2026, 20:01 Clemens Stolle, ***@***.***> wrote: > *klaemo* left a comment (apache/couchdb-nano#381) > <https://github.com/apache/couchdb-nano/issues/381#issuecomment-6452240170> > > Yes, option 2 works for me, and it fits the zero-dependency goal best. > > I tried it with a minimal interface inside the nano namespace and removed > the undici import: > > interface Dispatcher { > dispatch(options: object, handler: object): boolean;} > > With undici 7 installed, Agent, MockAgent, Pool, ProxyAgent, RetryAgent, > getGlobalDispatcher() and agent.compose(...) are all accepted. Keeping > undici as a devDependency for the test mocks is fine, because the published > types no longer reference it. > > The trade-off is that the type only checks for a dispatch method, not > undici's full Dispatcher API. nano only passes the value through to fetch, > so that's all it needs. > > The fix for #380 <https://github.com/apache/couchdb-nano/issues/380> > changes the same agentOptions line, so I'd put both in one small PR > together with the missing parseUrl from #362 > <https://github.com/apache/couchdb-nano/issues/362>, if that's OK with > you. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/couchdb-nano/issues/381?email_source=notifications&email_token=AAFKMRLIFXFZXDSVXCSNIUL5WD5LJA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNBVGIZDIMBRG4YKM4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-6452240170>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAFKMRI5Y4CHDLL7336MGI35WD5LJAVCNFSNUABEKJSXA33TNF2G64TZHMZTSMBVHEZDEMJ3JFZXG5LFHM3DANBRGA4DAOBTGSQXMAQ> > . > Triage notifications, keep track of coding agent tasks and review pull > requests on the go with GitHub Mobile for iOS > <https://github.com/notifications/mobile/ios/AAFKMROUNMIUT7YYE24S4T35WD5LJA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNBVGIZDIMBRG4YKM4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJKTGN5XXIZLSL5UW64Y> > and Android > <https://github.com/notifications/mobile/android/AAFKMRPFZNA2BJPSLB56KX35WD5LJA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNBVGIZDIMBRG4YKM4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>. > Download it today! > You are receiving this because you commented.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
