ralf0131 commented on a change in pull request #2079: [Dubbo-2064] Ipv6 support
URL: https://github.com/apache/incubator-dubbo/pull/2079#discussion_r206801322
 
 

 ##########
 File path: 
dubbo-common/src/test/java/org/apache/dubbo/common/utils/NetUtilsTest.java
 ##########
 @@ -180,4 +181,23 @@ public void testToURL() throws Exception {
         String url = NetUtils.toURL("dubbo", "host", 1234, "foo");
         assertThat(url, equalTo("dubbo://host:1234/foo"));
     }
+
+    @Test
+    public void testIsValidV6Address() {
+        System.setProperty("java.net.preferIPv6Addresses", "true");
 
 Review comment:
   Good catch, it is better.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to