carryxyh commented on a change in pull request #2185: Direct return when the
server goes down unnormally.
URL: https://github.com/apache/incubator-dubbo/pull/2185#discussion_r212177862
##########
File path:
dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/exchange/support/DefaultFuture.java
##########
@@ -108,11 +129,34 @@ public static void sent(Channel channel, Request
request) {
}
}
+ /**
+ * close a channel when a channel is inactive
+ * directly return the unfinished requests.
+ *
+ * @param channel
+ */
+ public static void closeChannel(Channel channel) {
Review comment:
Looks good to me! I’ll fix it soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
