Amazing implementation. But we should avoid `synchronized` as much as possible, besides this synchronization block is too large to effect performance:
> Synchronized lock is an auto-upgrade lock from light weight lock in object > header (when no concurrent) to monitor lock. So if the code block can be > executed fast enough we may get a light weight lock mostly. This is not true in this scenario, since it is very possible that multiple threads execute `doSelect` at the same moment. I am fine with other parts, but this synchronization block is my major concern. [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2647 ] This message was relayed via gitbox.apache.org for [email protected]
--------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
