1kasa commented on code in PR #2879:
URL: https://github.com/apache/dubbo-go/pull/2879#discussion_r2094138365
##########
registry/nacos/registry.go:
##########
@@ -58,6 +66,7 @@ type nacosRegistry struct {
*common.URL
namingClient *nacosClient.NacosNamingClient
registryUrls []*common.URL
+ done chan struct{}
Review Comment:
The done channel is closed (closed) to mark nacosRegistry as completed or
called, rather than by sending a signal to it. The specific code location is
```
select {
case <-nr.done:
default:
close(nr.done)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
